Contents
V678. Object is used as an argument to its own method. Consider checking the first actual argument of the 'Foo' function.
The analyzer has detected a call to a non-static member function in which the object itself was passed as the first argument.
A.Foo(A);This code may probably contain an error. For example, an incorrect variable name is used because of a misprint. The correct code should look like this then:
A.Foo(B);or like this:
B.Foo(A);Let's see how such misprints may affect the code in real life. Here's a fragment from a real application:
CXMLAttribute* pAttr1 =
m_pXML->GetAttribute(CXMLAttribute::schemaName);
CXMLAttribute* pAttr2 =
pXML->GetAttribute(CXMLAttribute::schemaName);
if ( pAttr1 && pAttr2 &&
!pAttr1->GetValue().CompareNoCase(pAttr1->GetValue()))
....This code should compare two attributes. But a misprint causes the value "pAttr1->GetValue()" to be compared to itself.
This is the fixed code:
if ( pAttr1 && pAttr2 &&
!pAttr1->GetValue().CompareNoCase(pAttr2->GetValue()))This diagnostic is classified as:
You can look at examples of errors detected by the V678 diagnostic. |
Was this page helpful?
