Contents
V3172. The 'if/if-else/for/while/foreach' statement and code block after it are not related. Inspect the program's logic.
The analyzer found a possible error. The 'if/if-else/for/while/foreach' statement and the code block ('{ .... }') after it are not related.
Consider a synthetic example:
if (a == 1) DoSmt();
{
DoSmt2();
}At first glance, the block seems to be executed if the condition is true, in fact, it is not so. The block is always executed, regardless of the condition. This may mislead the programmer.
Let's consider other code examples that trigger the analyzer:
if (a == 2) Nop(); else Nop2();
{
Nop3();
}
if (a == 3) Nop();
else Nop2();
{
Nop3();
}
foreach (var item in query) DoSmt1();
{
DoSmt2();
}The analyzer does not issue a warning if the lines with the statement and the unrelated code block are non-contiguous:
if (a == 7) DoSmt();
// this is a block for initializing MyClass fields
{
....
}If you get such a warning, and it is false, you can tell the analyzer about it by adding an empty line between the statement and the block.
Also, the diagnostic does not issue a warning if the statement body is empty (';'). The diagnostic rule V3007 is responsible for this.
if (a == 3) ;
{
DoSmt();
}This diagnostic is classified as:
Was this page helpful?
