Our website uses cookies to enhance your browsing experience.
Accept
to the top
>
>
>
V1057. Pseudo random sequence is the...
menu mobile close menu
Analyzing projects
Additional information
toggle menu Contents

V1057. Pseudo random sequence is the same at every program run. Consider assigning the seed to a value not known at compile-time.

May 08 2020

The analyzer has detected suspicious code initializing the pseudorandom number generator to a constant value.

// C
srand(0);
// C++
std::mt19937 engine(1);

When initialized in such a way, the generator will be producing a predictable sequence of numbers or the same number at every run.

To avoid this, assign the seed to some random number such as the current system time:

srand(time(0));

However, this approach may lead to issues in multithreaded applications: 'time(0)' may return identical values in different threads. Also, keep in mind that the user could change the time settings.

Starting with C++11, the 'std::random_device' generator is available, which implements an interface to the true-random number generator:

std::random_device rd;
std::mt19937 engine(rd());

However, if your system lacks such a generator, the regular pseudorandom number generator will be used.

This diagnostic rule is classified as: