To get a trial key
fill out the form below
Team License (a basic version)
Enterprise License (extended version)
* By clicking this button you agree to our Privacy Policy statement

Request our prices
New License
License Renewal
--Select currency--
* By clicking this button you agree to our Privacy Policy statement

Free PVS-Studio license for Microsoft MVP specialists
* By clicking this button you agree to our Privacy Policy statement

To get the licence for your open-source project, please fill out this form
* By clicking this button you agree to our Privacy Policy statement

I am interested to try it on the platforms:
* By clicking this button you agree to our Privacy Policy statement

Message submitted.

Your message has been sent. We will email you at

If you haven't received our response, please do the following:
check your Spam/Junk folder and click the "Not Spam" button for our message.
This way, you won't miss messages from our team in the future.

Knee-deep in C++ s... code

Knee-deep in C++ s... code

Mar 01 2011

Perhaps many of you know the site If not, I recommend those of you who think of themselves as programmers to visit it. Good mood is guaranteed!

This is how the site describes itself:

Found or squeezed out code you can't call fine, code you can't help laughing at? Do not rush at deleting or refactoring it - post it at, let's laugh together!

I, due to my occupation, spend much time on meditation upon very diverse C++ code. So, as they say, I have just enough of that stuff stored up. I can't carry this anymore inside me. Excuse me, but I will share it with you too.

Here you are the Top 10 of the "best" code fragments I've collected recently. These samples have one significant difference from those collected at the site "". While many of those samples are taken from students' works and private little-known projects, my samples are taken from reputable sources. These are well known open-source applications and libraries. Everyone have been using these projects and libraries regularly for many years. I won't name them since I believe it's unethical: one especially beautiful code fragment you might encounter in some project doesn't mean the bad quality of the whole project.

10. Fair election of candidates from parties TRUE and FALSE

m_bTypeED = ( nCmd == nCmd ) ? TRUE : FALSE;

9. Oh Lord, let the database always open - what is all that "frobnitz" for?

wstring myDBFName;
printf("Cannot open database %s",myDBFName);

8. You'd better not do such things with Ctrl-V

fhead[11] = '\0';
fhead[12] = '\0';
fhead[13] = '\0';
fhead[13] = '\0';

7. A nice and detailed comment is a good thing! But correct code is better

/** Deletes all previous field specifiers. 
  * This should be used when dealing with clients that 
  * send multiple NEP_PACKET_SPEC messages, so only the last
  * PacketSpec is taken into account. */
int NEPContext::resetClientFieldSpecs() {
  return OP_SUCCESS;
} /* End of resetClientFieldSpecs() */

6. Simple and smart

flag = true;
flag = false;
// flag is not used further anywhere

5. What if check fails at the first time...


Note. gameon and gamestarted are common variables of the bool type.

4. Original sin of Basic

t.printf("%10.5f, %10.5f, %10.5f,\n%10.5f, %10.5f, 
          %10.5f,\n%10.5f, %10.5f, %10.5f)",
         m[0, 0], m[0, 1], m[0, 2],
         m[1, 0], m[1, 1], m[1, 2],
         m[2, 0], m[2, 1], m[2, 2]);

3. A loop to conceive the Tao

for (i = 0; i < num_tbl; i++) {

2. Well, where will this file go after all? That'll do

FILE *fp;
if (! (fp = fopen(filename, "wb")) == -1) {
  perror("opening image file failed");

Note. This condition is always false thanks to two errors. Come on, find them, you pursuer of truth!

1. The first place goes to switch operator

    case (IDOK || IDCANCEL):


Well, there is one conclusion as always: he who makes no mistakes, makes nothing. No developer, even a skillful one, is secure from even silliest errors.

Popular related articles
PVS-Studio ROI

Date: Jan 30 2019

Author: Andrey Karpov

Occasionally, we're asked a question, what monetary value the company will receive from using PVS-Studio. We decided to draw up a response in the form of an article and provide tables, which will sho…
Characteristics of PVS-Studio Analyzer by the Example of EFL Core Libraries, 10-15% of False Positives

Date: Jul 31 2017

Author: Andrey Karpov

After I wrote quite a big article about the analysis of the Tizen OS code, I received a large number of questions concerning the percentage of false positives and the density of errors (how many erro…
Free PVS-Studio for those who develops open source projects

Date: Dec 22 2018

Author: Andrey Karpov

On the New 2019 year's eve, a PVS-Studio team decided to make a nice gift for all contributors of open-source projects hosted on GitHub, GitLab or Bitbucket. They are given free usage of PVS-Studio s…
The Evil within the Comparison Functions

Date: May 19 2017

Author: Andrey Karpov

Perhaps, readers remember my article titled "Last line effect". It describes a pattern I've once noticed: in most cases programmers make an error in the last line of similar text blocks. Now I want t…
The way static analyzers fight against false positives, and why they do it

Date: Mar 20 2017

Author: Andrey Karpov

In my previous article I wrote that I don't like the approach of evaluating the efficiency of static analyzers with the help of synthetic tests. In that article, I give the example of a code fragment…
Technologies used in the PVS-Studio code analyzer for finding bugs and potential vulnerabilities

Date: Nov 21 2018

Author: Andrey Karpov

A brief description of technologies used in the PVS-Studio tool, which let us effectively detect a large number of error patterns and potential vulnerabilities. The article describes the implementati…
Appreciate Static Code Analysis!

Date: Oct 16 2017

Author: Andrey Karpov

I am really astonished by the capabilities of static code analysis even though I am one of the developers of PVS-Studio analyzer myself. The tool surprised me the other day as it turned out to be sma…
The Last Line Effect

Date: May 31 2014

Author: Andrey Karpov

I have studied many errors caused by the use of the Copy-Paste method, and can assure you that programmers most often tend to make mistakes in the last fragment of a homogeneous code block. I have ne…
Static analysis as part of the development process in Unreal Engine

Date: Jun 27 2017

Author: Andrey Karpov

Unreal Engine continues to develop as new code is added and previously written code is changed. What is the inevitable consequence of ongoing development in a project? The emergence of new bugs in th…
PVS-Studio for Java

Date: Jan 17 2019

Author: Andrey Karpov

In the seventh version of the PVS-Studio static analyzer, we added support of the Java language. It's time for a brief story of how we've started making support of the Java language, how far we've co…

Comments (0)

Next comments
This website uses cookies and other technology to provide you a more personalized experience. By continuing the view of our web-pages you accept the terms of using these files. If you don't want your personal data to be processed, please, leave this site.
Learn More →