To get a trial key
fill out the form below
Team License (standard version)
Enterprise License (extended version)
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
Request our prices
New License
License Renewal
--Select currency--
USD
EUR
GBP
RUB
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
To get the licence for your open-source project, please fill out this form
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
To get the licence for your open-source project, please fill out this form
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
I am interested to try it on the platforms:
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
Message submitted.

Your message has been sent. We will email you at


If you haven't received our response, please do the following:
check your Spam/Junk folder and click the "Not Spam" button for our message.
This way, you won't miss messages from our team in the future.

>
>
Examples of errors detected by the V529…

Examples of errors detected by the V529 diagnostic

Apr 05 2021

V529. Odd semicolon ';' after 'if/for/while' operator.


Xpdf

V529 Odd semicolon ';' after 'if' operator. AFPDFLib queue.h 66


BOOL AddTail(LPVOID p)
{
  ....
  if(queue.GetSize() >= this->_limit);
  {
    while(queue.GetSize() > this->_limit-1)
    {
      ::WaitForSingleObject(handles[SemaphoreIndex], 1);
      queue.Delete(0);
    }
  }
  ....
}

Multi-threaded Dynamic Queue

V529 Odd semicolon ';' after 'while' operator. StandardQueues mtqueueproducer.cpp 35


void CMTQueueProducer::Reset()
{
  void* pMsg = NULL;
  CSimpleMessage* pDecodedMsg = NULL;
  while(TheQueueBuffer::GetInstance()->Pop(pMsg));
  {
    pDecodedMsg = (CSimpleMessage*) pMsg;
    if (pDecodedMsg)
    {
      try { delete pDecodedMsg; } catch (....) { NULL; }
    }
    pMsg = NULL;
  }
}

Fennec Media

V529 Odd semicolon ';' after 'for' operator. settings.c 483


int settings_default(void)
{
  ....
  for(i=0; i<16; i++);
    for(j=0; j<32; j++)
    {
      settings.conversion.equalizer_bands.boost[i][j] = 0.0;
      settings.conversion.equalizer_bands.preamp[i]   = 0.0;
    }
}

Fennec Media

V529 Odd semicolon ';' after 'for' operator. settings.c 913


int trans_rest(transcoder_settings *trans)
{
  ....
  for(i=0; i<16; i++);
  {
    trans->eq.eq.preamp[i]   = 0.0;
    for(j=0; j<32; j++)
    {
      trans->eq.eq.boost[i][j] = 0.0;
    }
  }
}

ReactOS

V529 Odd semicolon ';' after 'if' operator. tdi events.c 126


BOOLEAN
CTEScheduleEvent(PCTE_DELAYED_EVENT Event,
                 PVOID Context)
{
  ....
  if (!Event->Queued);
  {
    Event->Queued = TRUE;
    Event->Context = Context;
    ExQueueWorkItem(&Event->WorkItem, CriticalWorkQueue);
  }
  ....
}

Similar errors can be found in some other places:

  • V529 Odd semicolon ';' after 'if' operator. ntoskrnl mdlsup.c 1177

CamStudio

V529 Odd semicolon ';' after 'for' operator. boundary.c 3100


psd_static void psd_art_svp_render_aa_iter_step(....)
{
  ....
  /* move cursor to topmost vector which overlaps [y,y+1) */
  for(curs = 0; seg->points[curs + 1].y < y; curs++);
    cursor[i] = curs;
  ....
}

ReactOS

V529 Odd semicolon ';' after 'for' operator. environ.c 67


int BlockEnvToEnvironA(void)
{
  ....
  for (envptr--; envptr >= _environ; envptr--);
    free(*envptr);
  ....
}

Similar errors can be found in some other places:

  • V529 Odd semicolon ';' after 'for' operator. environ.c 119
  • V529 Odd semicolon ';' after 'for' operator. environ.c 171

Windows 8 Driver Samples

V529 Odd semicolon ';' after 'if' operator. hw_mac.c 95


NDIS_STATUS
HwSetPowerMgmtMode(....)
{
  ....
  if (!HW_MULTIPLE_MAC_ENABLED(Hw) &&
      (PMMode->dot11PowerMode != dot11_power_mode_unknown));
  {
    NdisMoveMemory(&Hw->MacState.PowerMgmtMode,
                   PMMode, sizeof(DOT11_POWER_MGMT_MODE));
    HalSetPowerMgmtMode(Hw->Hal, PMMode);
  }
  ....
}

QuickThread

V529 Odd semicolon ';' after 'if' operator. quickthread.cpp 670


QuickThreadCallNodeQueue* getCallNodeQueue(Affinities_bm& bm)
{
  ....
  if(temp->owningThreadNumber < 0);
    temp->owningThreadNumber = 0;
  ....
}

VirtualDub

V529 Odd semicolon ';' after 'while' operator. VirtualDub crash.cpp 462


static ModuleInfo *CrashGetModules(void *&ptr) {
  ....
  while(*pszHeap++);
    if (pszHeap[-1]=='.')
      period = pszHeap-1;
  ....
}

Oracle VM Virtual Box

V529 Odd semicolon ';' after 'for' operator. server_getshaders.c 92


void
SERVER_DISPATCH_APIENTRY crServerDispatchGetAttachedShaders(....)
{
  ....
  for (i=0; i<*pLocal; ++i);                          // <=
    ids[i] = crStateGLSLShaderHWIDtoID(ids[i]);
  ....
}

Haiku Operation System

V529 Odd semicolon ';' after 'for' operator. ringqueue.cpp 39


int
compute_order(unsigned long size)
{
  int  order;
  unsigned long tmp;
  for (order = 0, tmp = size; tmp >>= 1; ++order); // <=
    if (size & ~(1 << order))
      ++order;
    return order;
}

Bizarre formatting, but the code works. I guess they wanted to show their best here, but it just didn't work out quite well. This loop calculates the value of the highest set order. That is, the original number is shifted until it equals to zero ((tmp >>= 1), and the number of iterations is calculated (++order). for (order = 0, tmp = size; tmp >>= 1; ++order); And this code if (size & ~(1 << order)) ++order; rounds it up. Basically, it's ceil(log2(N)), a common construction used for calculating the number of bits necessary for encoding N different elements.


MAME

V529 Odd semicolon ';' after 'if' operator. win32ui.c 2300


static BOOL GameCheck(void)
{
  ....
  i = ListView_FindItem(hwndList, -1, &lvfi);
  if (changed && i != -1);                          // <=
    ListView_RedrawItems(hwndList, i, i);
  if ((game_index % progBarStep) == 0)
    ProgressBarStep();
  game_index++;
  ....
}

Similar errors can be found in some other places:

  • V529 Odd semicolon ';' after 'if' operator. win32ui.c 2876

CryEngine V

V529 Odd semicolon ';' after 'for' operator. boolean3d.cpp 1314


int CTriMesh::Slice(....)
{
  ....
  bop_meshupdate *pmd = new bop_meshupdate, *pmd0;
  pmd->pMesh[0]=pmd->pMesh[1] = this;  AddRef();AddRef();
  for(pmd0=m_pMeshUpdate; pmd0->next; pmd0=pmd0->next); // <=
    pmd0->next = pmd;
  ....
}

GuiLite

V529 Odd semicolon ';' after 'while' operator. GuiLite.h 3413


#define CORRECT(x, high_limit, low_limit)  {\
  x = (x > high_limit) ? high_limit : x;\
  x = (x < low_limit) ? low_limit : x;\
}while(0)

void refresh_wave(unsigned char frame)
{
  ....
  CORRECT(y_min, m_wave_bottom, m_wave_top);
  ....
}

Popular related articles
The way static analyzers fight against false positives, and why they do it

Date: Mar 20 2017

Author: Andrey Karpov

In my previous article I wrote that I don't like the approach of evaluating the efficiency of static analyzers with the help of synthetic tests. In that article, I give the example of a code fragment…
The Evil within the Comparison Functions

Date: May 19 2017

Author: Andrey Karpov

Perhaps, readers remember my article titled "Last line effect". It describes a pattern I've once noticed: in most cases programmers make an error in the last line of similar text blocks. Now I want t…
Technologies used in the PVS-Studio code analyzer for finding bugs and potential vulnerabilities

Date: Nov 21 2018

Author: Andrey Karpov

A brief description of technologies used in the PVS-Studio tool, which let us effectively detect a large number of error patterns and potential vulnerabilities. The article describes the implementati…
How PVS-Studio Proved to Be More Attentive Than Three and a Half Programmers

Date: Oct 22 2018

Author: Andrey Karpov

Just like other static analyzers, PVS-Studio often produces false positives. What you are about to read is a short story where I'll tell you how PVS-Studio proved, just one more time, to be more atte…
PVS-Studio for Java

Date: Jan 17 2019

Author: Andrey Karpov

In the seventh version of the PVS-Studio static analyzer, we added support of the Java language. It's time for a brief story of how we've started making support of the Java language, how far we've co…
The Ultimate Question of Programming, Refactoring, and Everything

Date: Apr 14 2016

Author: Andrey Karpov

Yes, you've guessed correctly - the answer is "42". In this article you will find 42 recommendations about coding in C++ that can help a programmer avoid a lot of errors, save time and effort. The au…
PVS-Studio ROI

Date: Jan 30 2019

Author: Andrey Karpov

Occasionally, we're asked a question, what monetary value the company will receive from using PVS-Studio. We decided to draw up a response in the form of an article and provide tables, which will sho…
Static analysis as part of the development process in Unreal Engine

Date: Jun 27 2017

Author: Andrey Karpov

Unreal Engine continues to develop as new code is added and previously written code is changed. What is the inevitable consequence of ongoing development in a project? The emergence of new bugs in th…
The Last Line Effect

Date: May 31 2014

Author: Andrey Karpov

I have studied many errors caused by the use of the Copy-Paste method, and can assure you that programmers most often tend to make mistakes in the last fragment of a homogeneous code block. I have ne…
Appreciate Static Code Analysis!

Date: Oct 16 2017

Author: Andrey Karpov

I am really astonished by the capabilities of static code analysis even though I am one of the developers of PVS-Studio analyzer myself. The tool surprised me the other day as it turned out to be sma…

Comments (0)

Next comments

This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
This website uses cookies and other technology to provide you a more personalized experience. By continuing the view of our web-pages you accept the terms of using these files. If you don't want your personal data to be processed, please, leave this site.
Learn More →
Accept