Our website uses cookies to enhance your browsing experience.
Accept
to the top
>
>
>
Examples of errors detected by the V303…

Examples of errors detected by the V3031 diagnostic

V3031. An excessive check can be simplified. The operator '||' operator is surrounded by opposite expressions 'x' and '!x'.


SharpDevelop

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions. DockablePane.cs 549


internal override ManagedContent RemoveContent(int index)
{
  ....
  if (((dockableContent == null)
      || (dockableContent != null &&
          dockableContent.SavedStateAndPosition == null)
      || (dockableContent != null &&
          dockableContent.SavedStateAndPosition.ContainerPane
          != this))
      && Items.Count == 0)
  ....
}

There is no error here, but the code can be simplified. "dockableContent != null" checks are not necessary here.


Xamarin.Forms

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions. Xamarin.Forms.Platform.iOS.Classic ContextActionCell.cs 102


public override void LayoutSubviews()
{
  ....
  if (_scroller == null || (_scroller != null &&
                            _scroller.Frame == Bounds))
    return;
  ....
}

There is no error here, but the code can be simplified.


FlashDevelop

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions. DockContentHandler.cs 540


internal void SetDockState(....)
{
  ....
  if ((Pane != oldPane) || (Pane == oldPane
    && oldDockState != oldPane.DockState))
  {
    RefreshDockPane(Pane);
  }
  ....
}

There is no error here, however, the conditions Pane != oldPane and Pane == oldPane are mutually exclusive, so this expression can be simplified


Mono

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions. mcs-net_4_x ILGenerator.cs 456


public void Emit(OpCode opc)
{
  Debug.Assert(opc != OpCodes.Ret || (
               opc == OpCodes.Ret && stackHeight <= 1));
  ....
}

There is no error here, but the code can be simplified.


Mono

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions. System.Windows.Forms-net_4_x ContainerControl.cs 506


public bool Validate (bool checkAutoValidate)
{
  if ((checkAutoValidate &&
      (AutoValidate != AutoValidate.Disable)) ||
      !checkAutoValidate)
    return Validate ();

  return true;
}

There is no error here, but the code can be simplified.


Orchard CMS

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions '!ssl' and 'ssl && CdnSupportsSsl'. ResourceDefinition.cs 190


public string ResolveUrl(....) {
  ....
  if (!ssl || (ssl && CdnSupportsSsl)) {
    ....
  }
}

Telerik UI for UWP

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions. SelectedItemCollection.cs 77


private bool CanInsertItem(object item)
{
  return    this.suspendLevel == 0
         && this.AllowSelect
         && ((!this.AllowMultipleSelect && this.Count == 0)
             || this.AllowMultipleSelect);
}

There is no error here, but the code can be simplified.

Similar errors can be found in some other places:

  • V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions. SelectedItemCollection.cs 93
  • V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions. StackVirtualizationStrategy.cs 49
  • V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions 'state == null' and 'state != null'. LocalFieldDescriptionsProviderBase.cs 24

RunUO

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions 'bPlayerOnly' and '!bPlayerOnly'. BaseCreature.cs 3005


public virtual double GetFightModeRanking( Mobile m,
                                           FightMode acqType,
                                           bool bPlayerOnly )
{
  if ( ( bPlayerOnly && m.Player ) ||  !bPlayerOnly )
  {
    ....
  }
  ....
}

RunUO

V3031 An excessive check can be simplified. The '||' operator is surrounded by opposite expressions 'pack == null' and 'pack != null'. BODBuyGump.cs 64


public override void OnResponse(Server.Network.NetState sender, RelayInfo info)
{
  ....
  if ( (pack == null) ||
       ((pack != null) &&
        (!pack.CheckHold(
                m_From,
                item,
                true,
                true,
                0,
                item.PileWeight + item.TotalWeight)) ) )
  {
    pv.SayTo(m_From, 503204);
    m_From.SendGump(new BOBGump(m_From, m_Book, m_Page, null));
  }
  ....
}

close form

Fill out the form in 2 simple steps below:

Your contact information:

Step 1
Congratulations! This is your promo code!

Desired license type:

Step 2
Team license
Enterprise license
** By clicking this button you agree to our Privacy Policy statement
close form
Request our prices
New License
License Renewal
--Select currency--
USD
EUR
* By clicking this button you agree to our Privacy Policy statement

close form
Free PVS‑Studio license for Microsoft MVP specialists
* By clicking this button you agree to our Privacy Policy statement

close form
To get the licence for your open-source project, please fill out this form
* By clicking this button you agree to our Privacy Policy statement

close form
I am interested to try it on the platforms:
* By clicking this button you agree to our Privacy Policy statement

close form
check circle
Message submitted.

Your message has been sent. We will email you at


If you do not see the email in your inbox, please check if it is filtered to one of the following folders:

  • Promotion
  • Updates
  • Spam