To get a trial key
fill out the form below
Team License (standard version)
Enterprise License (extended version)
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
Request our prices
New License
License Renewal
--Select currency--
USD
EUR
GBP
RUB
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
To get the licence for your open-source project, please fill out this form
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
To get the licence for your open-source project, please fill out this form
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
I am interested to try it on the platforms:
* By clicking this button you agree to our Privacy Policy statement

** This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
Message submitted.

Your message has been sent. We will email you at


If you haven't received our response, please do the following:
check your Spam/Junk folder and click the "Not Spam" button for our message.
This way, you won't miss messages from our team in the future.

>
>
Examples of errors detected by the V676…

Examples of errors detected by the V676 diagnostic

Apr 05 2021

V676. It is incorrect to compare the variable of BOOL type with TRUE.


VirtualDub

V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'ChooseColorA(& cc) != FALSE'. VirtualDub gui.cpp 665


bool guiChooseColor(HWND hwnd, COLORREF& rgbOld) {
  ....
  if (ChooseColor(&cc)==TRUE) {;
    rgbOld = cc.rgbResult;
    return true;
  }
  ....
}

If the user clicks the OK button of the dialog box, the return value is **nonzero**.

Similar errors can be found in some other places:

  • V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'ChooseColorA(& cc) != FALSE'. VDFilters vfrotate2.cpp 54

Firebird

V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'success == FALSE'. iscguard.cpp 667


THREAD_ENTRY_DECLARE start_and_watch_server(THREAD_ENTRY_PARAM)
{
  ....
  success = CreateProcess(....);
  if (success != TRUE)
    error = GetLastError();
  ....
}

#info If the function succeeds, the return value is nonzero.

Similar errors can be found in some other places:

  • V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'success == FALSE'. iscguard.cpp 691
  • V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: '(* m_funct)(lpCS) != FALSE'. locks.h 64
  • V676 It is incorrect to compare the variable of BOOL type with TRUE. iscguard.cpp 614
  • And 2 additional diagnostic messages.

CryEngine 3 SDK

V676 It is incorrect to compare the variable of BOOL type with TRUE. statsagentpipe.cpp 163


bool CStatsAgentPipe::Send()
{
  ....
  ok = ::WriteFile(s_pipe, pBuffer.c_str(), nBytes, &tx, 0)
       == TRUE;
  ....
}

Similar errors can be found in some other places:

  • V676 It is incorrect to compare the variable of BOOL type with TRUE. statsagentpipe.cpp 108

Apple II emulator

V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'out != FALSE'. frame.cpp 381


typedef int BOOL;

static void Draw3dRect (...., BOOL out)
{
  ....
  SelectObject(dc,(out == 1) ? btnhighlightpen : btnshadowpen);
  ....
}

Amazon FreeRTOS

V676 [CWE-253] It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'FALSE != CryptGenRandom(hProv, len, output)'. aws_entropy_hardware_poll.c 51


int mbedtls_hardware_poll(void* data,
                          unsigned char* output,
                          size_t len,
                          size_t* olen)
{
  int lStatus = MBEDTLS_ERR_ENTROPY_SOURCE_FAILED;
  HCRYPTPROV hProv = 0;

  /* Unferenced parameter. */
  (void)data;

  /*
   * This is port-specific for the Windows simulator,
   * so just use Crypto API.
   */

  if (TRUE == CryptAcquireContextA(
                &hProv, NULL, NULL,
                PROV_RSA_FULL,
                CRYPT_VERIFYCONTEXT))
  {
    if (TRUE == CryptGenRandom(hProv, len, output))
    {
      lStatus = 0;
      *olen = len;
    }

    CryptReleaseContext(hProv, 0);
  }

  return lStatus;
}

Similar errors can be found in some other places:

  • V676 [CWE-253] It is incorrect to compare the variable of BOOL type with TRUE. aws_entropy_hardware_poll.c 48

Popular related articles
The Evil within the Comparison Functions

Date: May 19 2017

Author: Andrey Karpov

Perhaps, readers remember my article titled "Last line effect". It describes a pattern I've once noticed: in most cases programmers make an error in the last line of similar text blocks. Now I want t…
Characteristics of PVS-Studio Analyzer by the Example of EFL Core Libraries, 10-15% of False Positives

Date: Jul 31 2017

Author: Andrey Karpov

After I wrote quite a big article about the analysis of the Tizen OS code, I received a large number of questions concerning the percentage of false positives and the density of errors (how many erro…
PVS-Studio ROI

Date: Jan 30 2019

Author: Andrey Karpov

Occasionally, we're asked a question, what monetary value the company will receive from using PVS-Studio. We decided to draw up a response in the form of an article and provide tables, which will sho…
The Last Line Effect

Date: May 31 2014

Author: Andrey Karpov

I have studied many errors caused by the use of the Copy-Paste method, and can assure you that programmers most often tend to make mistakes in the last fragment of a homogeneous code block. I have ne…
Free PVS-Studio for those who develops open source projects

Date: Dec 22 2018

Author: Andrey Karpov

On the New 2019 year's eve, a PVS-Studio team decided to make a nice gift for all contributors of open-source projects hosted on GitHub, GitLab or Bitbucket. They are given free usage of PVS-Studio s…
The Ultimate Question of Programming, Refactoring, and Everything

Date: Apr 14 2016

Author: Andrey Karpov

Yes, you've guessed correctly - the answer is "42". In this article you will find 42 recommendations about coding in C++ that can help a programmer avoid a lot of errors, save time and effort. The au…
Technologies used in the PVS-Studio code analyzer for finding bugs and potential vulnerabilities

Date: Nov 21 2018

Author: Andrey Karpov

A brief description of technologies used in the PVS-Studio tool, which let us effectively detect a large number of error patterns and potential vulnerabilities. The article describes the implementati…
PVS-Studio for Java

Date: Jan 17 2019

Author: Andrey Karpov

In the seventh version of the PVS-Studio static analyzer, we added support of the Java language. It's time for a brief story of how we've started making support of the Java language, how far we've co…
Appreciate Static Code Analysis!

Date: Oct 16 2017

Author: Andrey Karpov

I am really astonished by the capabilities of static code analysis even though I am one of the developers of PVS-Studio analyzer myself. The tool surprised me the other day as it turned out to be sma…
The way static analyzers fight against false positives, and why they do it

Date: Mar 20 2017

Author: Andrey Karpov

In my previous article I wrote that I don't like the approach of evaluating the efficiency of static analyzers with the help of synthetic tests. In that article, I give the example of a code fragment…

Comments (0)

Next comments

This site is protected by reCAPTCHA and the Google Privacy Policy and Terms of Service apply.
This website uses cookies and other technology to provide you a more personalized experience. By continuing the view of our web-pages you accept the terms of using these files. If you don't want your personal data to be processed, please, leave this site.
Learn More →
Accept