Examples of errors detected by the V678 diagnostic

V678. Object is used as an argument to its own method. Consider checking the first actual argument of the 'Foo' function.

OpenCV

V678 An object is used as an argument to its own method. Consider checking the first actual argument of the 'copyTo' function. ocl_test.cpp 107

double TestUtils::checkRectSimilarity(const Size & sz,
  std::vector<Rect>& ob1, std::vector<Rect>& ob2)
{
  double final_test_result = 0.0;
  size_t sz1 = ob1.size();
  size_t sz2 = ob2.size();

  if (sz1 != sz2)
    return sz1 > sz2 ? (double)(sz1 - sz2) : (double)(sz2 - sz1);
  else
  {
    if (sz1 == 0 && sz2 == 0)
      return 0;
    cv::Mat cpu_result(sz, CV_8UC1);
    cpu_result.setTo(0);

    for (vector<Rect>::const_iterator r = ob1.begin(); r != ob1.end(); ++r)
    {
      cv::Mat cpu_result_roi(cpu_result, *r);
      cpu_result_roi.setTo(1);
      cpu_result.copyTo(cpu_result);          // <=
    }
    // ....
  }
}

Similar errors can be found in some other places:

• V678 An object is used as an argument to its own method. Consider checking the first actual argument of the 'copyTo' function. ocl_test.cpp 117

ROOT

V678 An object is used as an argument to its own method. Consider checking the first actual argument of the 'Copy' function. TFormLeafInfo.cxx 2414

TFormLeafInfoMultiVarDim::TFormLeafInfoMultiVarDim(
  const TFormLeafInfoMultiVarDim& orig) : TFormLeafInfo(orig)
{
   fNsize = orig.fNsize;
   fSizes.Copy(fSizes);   // <=
   fCounter2 = orig.fCounter2?orig.fCounter2->DeepCopy():0;
   fSumOfSizes = orig.fSumOfSizes;
   fDim = orig.fDim;
   fVirtDim = orig.fVirtDim;
   fPrimaryIndex = orig.fPrimaryIndex;
   fSecondaryIndex = orig.fSecondaryIndex;
}

Mozilla Thunderbird

V678 An object is used as an argument to its own method. Consider checking the first actual argument of the 'Assign' function. nsgenerichtmlelement.h 411

class nsGenericHTMLElement : public nsGenericHTMLElementBase,
                             public nsIDOMHTMLElement
{
  ....
  NS_IMETHOD GetItemId(nsAString& aId) final override {
    nsString id;
    GetItemId(id);
    aId.Assign(aId);
    return NS_OK;
  }
  ....
}

Shareaza

V678 An object is used as an argument to its own method. Consider checking the first actual argument of the 'CompareNoCase' function. downloadwithsources.cpp 1281

void CDownloadWithSources::MergeMetadata(
  const CXMLElement* pXML)
{
  CQuickLock pLock( Transfers.m_pSection );

  CXMLAttribute* pAttr1 =
    m_pXML->GetAttribute(CXMLAttribute::schemaName);
  CXMLAttribute* pAttr2 =
    pXML->GetAttribute(CXMLAttribute::schemaName);

  if (pAttr1 && pAttr2 &&
      !pAttr1->GetValue().CompareNoCase(pAttr1->GetValue()))
    ....
}